Add eslint-plugin-jest #11119
Merged
Add eslint-plugin-jest #11119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
commented
Feb 10, 2020
| }).toThrow(/.plugins[0][1] must be an object, false, or undefined/); | ||
| }); | ||
| }); | ||
| }).toThrow(".plugins[0][1] must be an object, false, or undefined"); |
There was a problem hiding this comment.
toThrow is chained at wrong function. Unfortunately it will always pass and eslint-plugin-jest helps detecting such bugs.
JLHwung
commented
Feb 10, 2020
| @@ -422,7 +422,11 @@ describe("scope", () => { | |||
| } | |||
| }); | |||
|
|
|||
| /*if (kind1 !== kind2) { | |||
| if (kind1 !== kind2) { | |||
There was a problem hiding this comment.
JLHwung
added
area: eslint
PR: Internal 🏠
nicolo-ribaudo
approved these changes
Feb 10, 2020
existentialism
approved these changes
Feb 10, 2020
rajasekarm
pushed a commit
to rajasekarm/babel
that referenced
this pull request
Feb 17, 2020
* chore: add eslint-plugin-jest * chore: update test sources * chore: suppress preset-env debug log when linting
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint-plugin-jestto root devDependenciesThis PR introduces
eslint-plugin-jestto lint our test sources. It catches several test source bugs. Note that some rules are disabled as the change is not that straightforward and thus better toggle on later.