Fix typing of ReplaceSupers options #11121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick fix.
```NodeJs
opts: {
getObjetRef: Function,
methodPath: NodePath,
superRef: Object,
isLoose: boolean,
file: any,
};
```
Should be:
```Nodejs
opts: {
getObjectRef: Function,
methodPath: NodePath,
superRef: Object,
isLoose: boolean,
file: any,
};
```
I think this should do it, right? Let me know if you need anything else changed.
existentialism
added
area: flow
PR: Internal 🏠
JLHwung
approved these changes
Feb 10, 2020
nicolo-ribaudo
approved these changes
Feb 11, 2020
|
Thanks for checking old PRs! |
rajasekarm
pushed a commit
to rajasekarm/babel
that referenced
this pull request
Feb 17, 2020
* Fix type opts.getObjetRef to opts.getObjectRef * Added // @flow to possibly catch for more errors. * tweaks Co-authored-by: InsignificantReasons <41794038+InsignificantReasons@users.noreply.github.com>
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping to clear some open PRs... this revives #10048