Allow await when it is not in AsyncArrowHead #11148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arku
force-pushed
the
fix/async-identifiers-outside-async-functions
branch
from
eda041d
to
19aa381
Compare
nicolo-ribaudo
added
pkg: parser
PR: Bug Fix 🐛
arku
force-pushed
the
fix/async-identifiers-outside-async-functions
branch
from
19aa381
to
99c07ae
Compare
| @@ -59,6 +59,7 @@ export default class State { | |||
| // Flags to track | |||
| inParameters: boolean = false; | |||
| maybeInArrowParameters: boolean = false; | |||
| maybeInAsyncArrowHead: boolean = false; | |||
There was a problem hiding this comment.
It's not clear to me what the difference between these two flags should be. Isn't the arrow head its parameters?
There was a problem hiding this comment.
The maybeInAsyncArrowHead lives across function declarations.
async (foo = function (await) {}) => {}When parsing await, maybeInAsyncArrowHead is true but maybeInArrowParameters is false.
There was a problem hiding this comment.
We should add a comment in the code explaining it 👍
There was a problem hiding this comment.
@nicolo-ribaudo Done. Let me know if we can make it better.
arku
force-pushed
the
fix/async-identifiers-outside-async-functions
branch
2 times, most recently
from
0964918
to
bc35c6a
Compare
Comment on lines
564
to
566
| if (state.maybeAsyncArrow) { | ||
| this.state.maybeInAsyncArrowHead = state.maybeAsyncArrow; | ||
| } |
There was a problem hiding this comment.
Nit: inside the if state.maybeAsyncArrow is always true.
Suggested change
| if (state.maybeAsyncArrow) { | |
| this.state.maybeInAsyncArrowHead = state.maybeAsyncArrow; | |
| } | |
| if (state.maybeAsyncArrow) this.state.maybeInAsyncArrowHead = true; |
There was a problem hiding this comment.
@nicolo-ribaudo Ah, yeah. Just updated the PR.
arku
force-pushed
the
fix/async-identifiers-outside-async-functions
branch
from
bc35c6a
to
2d07de2
Compare
arku
force-pushed
the
fix/async-identifiers-outside-async-functions
branch
from
2d07de2
to
cc7cc42
Compare
This was referenced Mar 22, 2020
This was referenced Mar 30, 2020
This was referenced Apr 12, 2020
This was referenced Apr 20, 2020
This was referenced Apr 27, 2020
This was referenced May 5, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the parser error thrown for the input
(await) => {}. I tried to fix the other cases mentioned in the issue description and after struggling with delaying the await position check in case of async call expressions, I reached out to @JLHwung for help. He added that the delay check is indeed difficult and it is best to refactor the await position tracking with a scope based recording mechanism that is non-trivial.