Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable more eslint recommended rules #11168

Merged
merged 7 commits into from Feb 25, 2020
Merged

Enable more eslint recommended rules #11168

merged 7 commits into from Feb 25, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Feb 24, 2020

Q                       A
License MIT

This enables more eslint:recommended rules and remove all the other rules that is not activated by default.

The new babel-eslint-config-internal can be a good start if we prefer to enable more custom rules.

@JLHwung JLHwung added PR: Internal 🏠 A type of pull request used for our changelog categories area: eslint labels Feb 24, 2020
nicolo-ribaudo
nicolo-ribaudo approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesss

@JLHwung JLHwung force-pushed the enable-more-eslint-recommended-rules branch from ee4f8ae to 3a09eb2 Compare February 24, 2020 22:51
existentialism
existentialism approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

@JLHwung JLHwung merged commit afb0f48 into babel:master Feb 25, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the enable-more-eslint-recommended-rules branch February 25, 2020 00:23
kaicataldo
kaicataldo reviewed Feb 25, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late to the party, but 🙌

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 26, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaicataldo kaicataldo kaicataldo left review comments

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: eslint outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JLHwung @existentialism @nicolo-ribaudo @kaicataldo