Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace gulp-watch by gulp.watch #11175

Merged
merged 2 commits into from Feb 26, 2020
Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Feb 26, 2020

Q                       A
Fixed Issues? When running make watch for a long time after several git checkout, multiple file watchers are registered
Any Dependency Changes? gulp-watch is removed
License MIT

When running make watch for a long time and after several git checkout, gulp-watch will register multiple file watchers for a single file. It seems to me the file watcher is leaking.

Replacing gulp-watch with builtin gulp.watch seems to fix this issue.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Feb 26, 2020
@nicolo-ribaudo
Copy link
Member

We have had this problem since forever, but it was easier to restart make watch than to fix it 😆

{ debounceDelay: 200 },
gulp.task("build-no-bundle")
);
gulp.watch(defaultSourcesGlob, gulp.task("build-no-bundle"));
Copy link
Contributor Author

@JLHwung JLHwung Feb 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gulp.watch equivalent of { debouceDelay: 200 } is { delay: 200 }. According to https://gulpjs.com/docs/en/api/watch#options 200 is the default delay value, so we remove option argument here.

@JLHwung JLHwung merged commit e9ea523 into babel:master Feb 26, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the replace-gulp-watch branch February 26, 2020 23:13
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants