Pass URLs to import() rather than paths #11193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
11 tasks
jridgewell
approved these changes
Mar 1, 2020
|
All the failures are probably because |
nicolo-ribaudo
force-pushed
the
import-url
branch
from
86a5aca
to
a8a0afa
Compare
nicolo-ribaudo
force-pushed
the
import-url
branch
from
a8a0afa
to
2204c30
Compare
JLHwung
approved these changes
Mar 3, 2020
This was referenced Mar 7, 2020
This was referenced Mar 14, 2020
This was referenced Mar 22, 2020
This was referenced Apr 11, 2020
This was referenced Apr 20, 2020
This was referenced Apr 27, 2020
This was referenced May 5, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native
import()expects an URL, but we were passing it an absolute file path. It worked on linux, but fails on windows becauseC:is parsed as an URL protocol.nodejs/node#31710
We don't have tests for this, because Jest doesn't support native
import()yet.