Allow defining the moduleIds-related option in the transform plugins #11194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: New Feature 🚀
packages/babel-core/package.json
Outdated
| @@ -46,6 +46,7 @@ | |||
| "@babel/template": "^7.8.6", | |||
| "@babel/traverse": "^7.8.6", | |||
| "@babel/types": "^7.8.6", | |||
| "@babel/helper-module-transforms": "^7.8.6", | |||
existentialism
approved these changes
Mar 2, 2020
JLHwung
approved these changes
Mar 3, 2020
nicolo-ribaudo
added
the
PR: Ready to be Merged
- moduleIds - moduleId - getModuleId - moduleRoot
nicolo-ribaudo
force-pushed
the
add-module-ids-opts-to-transform-plugins
branch
from
009e29a
to
26800f5
Compare
This was referenced Mar 22, 2020
This was referenced Mar 30, 2020
This was referenced Apr 11, 2020
This was referenced Apr 13, 2020
This was referenced Apr 21, 2020
This was referenced Apr 29, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step towards #5473. I didn't move
filenameRelativesince it's not mentioned in the modules-related docs, and it's used as a default value forsourceFileName's option.When this PR is merged, I will open one in the
next-8-devbranch to remove the global options. This will make it easier to migrate before upgrading to Babel 8.