fix(babel-parser): chain off optionally chained keys named class and function #11198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flow did not trust that curContext.override would be defined
nicolo-ribaudo
added
pkg: parser
PR: Bug Fix 🐛
|
Thanks! |
nicolo-ribaudo
approved these changes
Mar 3, 2020
|
The build fails for node 10. It seems to work fine for node 6, 8 and 12. Could any of you maintainers (@nicolo-ribaudo) retry it? If that does not work, perhaps we should try replacing |
|
I restarted it, lets see. |
existentialism
approved these changes
Mar 3, 2020
|
Nice work, @Vages! |
JLHwung
approved these changes
Mar 3, 2020
This was referenced Mar 7, 2020
This was referenced Mar 14, 2020
This was referenced Mar 22, 2020
This was referenced Apr 11, 2020
This was referenced Apr 20, 2020
This was referenced Apr 27, 2020
This was referenced May 5, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to parse expressions such as those described in #11197. (This may be considered a minor upgrade, but I would not, as it does not extend the current API as much as it restores it to its expected behavior.)