Allow using preset-env with newer versions of compat-data
#11201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
JLHwung
reviewed
Mar 3, 2020
| @@ -11,7 +11,7 @@ | |||
| "repository": "https://github.com/babel/babel/tree/master/packages/babel-preset-env", | |||
| "main": "lib/index.js", | |||
| "dependencies": { | |||
| "@babel/compat-data": "^7.8.6", | |||
| "@babel/compat-data": "~7.8.6", | |||
There was a problem hiding this comment.
@babel/compat-data is also depended by @babel/helper-compilation-targets. By doing so we risk having two versions of @babel/compat-data if one installs preset-env + helper-compilation-targets 7.8.0 while compat-data 7.9.0 has been published.
Can we fix this on the preset-env side? So it can work with higher compat-data as long as we would not drop entries in minor releases. We can introduce an extra unit test as a sync reminder.
This reverts commit e7d57c7.
nicolo-ribaudo
changed the title
JLHwung
approved these changes
Mar 3, 2020
existentialism
approved these changes
Mar 4, 2020
nicolo-ribaudo
changed the title
preset-env with newer versions of compat-data
This was referenced Mar 7, 2020
This was referenced Mar 14, 2020
This was referenced Mar 22, 2020
bernd
added a commit
to Graylog2/graylog2-server
that referenced
this pull request
Mar 23, 2020
This fixes the following error when running "npm install" in
graylog-web-plugin:
error: [BABEL] graylog2-web-interface/packages/graylog-web-plugin/src/PluginManifest.js:
Could not find plugin "proposal-numeric-separator". Ensure there is an
entry in ./available-plugins.js for it.
Related PR in babel: babel/babel#11201
Fixes #7731
This was referenced Apr 11, 2020
This was referenced Apr 20, 2020
This was referenced Apr 27, 2020
This was referenced May 5, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, adding a new plugin to
@babel/compat-databreaks old@babel/preset-envversions. This is becausepreset-enviterates overcompat-data's plugins, and throws if the plugin isn't defined inpreset-env'savailable-plugins.jsfile.This was found in #10971 (review)
Instead of removing the error (which is useful to keep the two lists in sync), I propose to set
compat-data's version using~. This is enough to solve the problem, because adding new plugins tocompat-datais a new feature, requiring a minor version.This PR should be merged before 7.9.0: 7.8.0 was the first version with
@babel/compat-data, and we should fix it in 7.8.x so that people using"@babel/preset-env": "~7.8.0"don't get hit by this bug.