Support more node types in generateUidBasedOnNode #11260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
added
the
PR: Internal 🏠
jridgewell
force-pushed
the
generateUidBasedOnNode
branch
from
e54f079
to
00a5c05
Compare
nicolo-ribaudo
approved these changes
Mar 14, 2020
This was referenced Mar 22, 2020
This was referenced Mar 30, 2020
This was referenced Apr 11, 2020
This was referenced Apr 21, 2020
This was referenced Apr 29, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few new AST nodes to
generateUidBasedOnNode's internalgatherNodeParts. It also refactors it, because the constantif (t.isX() {} else if (t.isY()) {}was becoming very difficult to scan.