Add for-of fallback for arrays in browsers without symbol support #11263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: Bug Fix 🐛
1 task
nicolo-ribaudo
force-pushed
the
iterables-dx/for-of-helper
branch
from
4173b6c
to
771986f
Compare
nicolo-ribaudo
force-pushed
the
iterables-dx/for-of-no-symbol-allow-array
branch
from
d5b9ea3
to
fe088fe
Compare
nicolo-ribaudo
changed the base branch from
iterables-dx/for-of-helper
to
master
JLHwung
approved these changes
Mar 18, 2020
jridgewell
requested changes
Mar 18, 2020
| if (i >= o.length) return { done: true }; | ||
| return { done: false, value: o[i++] }; | ||
| }, | ||
| e: F, |
There was a problem hiding this comment.
This e method needs to throw the passed in error.
There was a problem hiding this comment.
Thanks, good catch!
jridgewell
approved these changes
Mar 19, 2020
This was referenced Mar 19, 2020
This was referenced Mar 22, 2020
This was referenced Mar 30, 2020
This was referenced Apr 12, 2020
This was referenced Apr 20, 2020
This was referenced Apr 27, 2020
This was referenced May 5, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to the
assumeArrayoption: it makes arrays work in browsers withoutSymbolsupport. It's safe to apply this by default, because for non-arrays it still goes in theSymbol.iteratorpath.This PR isn't really useful per se, but it's needed for Part 3 of this series.
Part 2/n
Depends on: