Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Purish aliases #11267

Merged
merged 2 commits into from Mar 16, 2020
Merged

Update Purish aliases #11267

merged 2 commits into from Mar 16, 2020

Conversation

jridgewell
Copy link
Member

Q                       A
Fixed Issues?
Patch: Bug Fix? Yes
Major: Breaking Change? ?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT
  • Adds Purish to RegexLiteral, since it can't cause any side-effects.
  • Removes Purish from ClassExpression and ClassDeclaration, since they can be impure with static class fields.

@jridgewell
Update Purish aliases
c33d5cc 
- Adds `Purish` to `RegexLiteral`, since it can't cause any side-effects.
- Removes `Purish` from `ClassExpression` and `ClassDeclaration`, since they can be impure with static class fields.
@jridgewell
Update types
c5b1576
@nicolo-ribaudo nicolo-ribaudo added pkg: types PR: Bug Fix 🐛 A type of pull request used for our changelog categories PR: Internal 🏠 A type of pull request used for our changelog categories and removed PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Mar 15, 2020
nicolo-ribaudo
nicolo-ribaudo approved these changes Mar 15, 2020
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Also ES2015-only classes can be impure, with computed keys. 😉

@nicolo-ribaudo nicolo-ribaudo merged commit 1005890 into babel:master Mar 16, 2020
@jridgewell jridgewell deleted the purish branch March 16, 2020 15:44
This was referenced Mar 22, 2020
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 30, 2020
Open
Open
Open
Open
This was referenced Apr 11, 2020
Merged
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 17, 2020
Open
Open
Open
Open
Open
This was referenced Apr 24, 2020
Open
Open
Open
Closed
Open
Open
Merged
This was referenced May 2, 2020
Open
Merged
Open
Closed
Open
Open
Open
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jridgewell @existentialism @JLHwung @nicolo-ribaudo