Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move object-rest-spread after transform-parameters #11280

Merged
merged 3 commits into from Mar 19, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Mar 18, 2020

Q                       A
Fixed Issues? Fixes #11278
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
License MIT

This PR only address the plugin ordering issue introduced at 7.8.0, which fixes the OP's issue. However, when investigating #11278, I realize that the following snippet is never transformed correctly with only object-rest-spread enabled. I will track this one in another issue.

function F({ a, ...O }, b = O){}

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories i: regression labels Mar 18, 2020
@existentialism
Copy link
Member

Won't this get reverted the next time build-data is run?

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should write this bigger 😆

// WARNING: Plugin ordering is important. Don't reorder this file

@nicolo-ribaudo nicolo-ribaudo merged commit 0a02a12 into babel:master Mar 19, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the fix-11278 branch March 19, 2020 16:08
shesek added a commit to Blockstream/esplora that referenced this pull request Mar 21, 2020
The regression introduced in babel v7.8.1 is now fixed:
babel/babel#11280
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 19, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid assignment order introduced in v7.8.0
3 participants