New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move object-rest-spread
after transform-parameters
#11280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
i: regression
labels
Mar 18, 2020
nicolo-ribaudo
approved these changes
Mar 18, 2020
Won't this get reverted the next time |
existentialism
approved these changes
Mar 19, 2020
nicolo-ribaudo
approved these changes
Mar 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should write this bigger 😆
// WARNING: Plugin ordering is important. Don't reorder this file |
shesek
added a commit
to Blockstream/esplora
that referenced
this pull request
Mar 21, 2020
The regression introduced in babel v7.8.1 is now fixed: babel/babel#11280
This was referenced Mar 22, 2020
This was referenced Mar 30, 2020
This was referenced Apr 11, 2020
This was referenced Apr 14, 2020
This was referenced Apr 22, 2020
This was referenced Apr 29, 2020
github-actions
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Jun 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
i: regression
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only address the plugin ordering issue introduced at 7.8.0, which fixes the OP's issue. However, when investigating #11278, I realize that the following snippet is never transformed correctly with only
object-rest-spread
enabled. I will track this one in another issue.