Add @babel/helper-validator-identifier #11289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Internal 🏠
nicolo-ribaudo
approved these changes
Mar 19, 2020
JLHwung
force-pushed
the
helper-validator-identifier
branch
from
f519a47
to
153c057
Compare
JLHwung
commented
Mar 19, 2020
| "access": "public" | ||
| }, | ||
| "main": "./lib/index.js", | ||
| "exports": "./lib/index.js", |
There was a problem hiding this comment.
Following practice from https://github.com/nodejs/node/pull/32098/files#diff-8e67f407bc32a0569e25d7ecaff6e494R208
"exports": string is supported on every version of node.js 13.
kaicataldo
approved these changes
Mar 20, 2020
JLHwung
force-pushed
the
helper-validator-identifier
branch
from
80343a1
to
8b34e8e
Compare
nicolo-ribaudo
approved these changes
Mar 20, 2020
This was referenced Mar 22, 2020
This was referenced Mar 30, 2020
This was referenced Apr 12, 2020
This was referenced Apr 20, 2020
This was referenced Apr 27, 2020
This was referenced May 5, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts most utilities of
babel-parser/utils/identifierinto a dedicated package. By doing so we can replaceesutilssince we only use a small faction (validation) of it.This PR also fixes the issue caused by out-of-dated Unicode version bundled by
esutils.