Correctly transpile when default parameter initializer references binding in rest pattern #11326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue 11281. Transform parameters with default initializers that have ids that are also in a parameter with a rest element. Before, these parameters were not transformed.
nicolo-ribaudo
added
PR: Bug Fix 馃悰
JLHwung
reviewed
Mar 25, 2020
JLHwung
reviewed
Mar 25, 2020
| @@ -213,8 +218,67 @@ export default declare((api, opts) => { | |||
| // function a({ b, ...c }) {} | |||
| Function(path) { | |||
| const params = path.get("params"); | |||
| for (let i = params.length - 1; i >= 0; i--) { | |||
| replaceRestElement(params[i].parentPath, params[i]); | |||
| const paramHasRestElement = []; | |||
There was a problem hiding this comment.
It suffices to model paramHasRestElement as Set<number> and to only include the index of which has rest element.
There was a problem hiding this comment.
Changed. I used an array of booleans instead of a set since the code was about the same length and I figured array access would be (very marginally) faster than set access.
JLHwung
reviewed
Mar 25, 2020
Previously, f({...R}, f = R => R) would be incorrectly transformed.
|
Any more feedback? |
JLHwung
reviewed
Mar 30, 2020
Checking the RHS of an assignment pattern/checking the parent of
an identifier node fails on cases like "({...R}, a = f(R))" or
"({...R}, {[R.key]: a = 42})".
Also refactor tests by removing unecessary tests and
separating "should transform" from "should not transform" tests.
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: If the title seems familiar, it is because I copied it from #11317, which I closed because I rewrote the code to a large degree, so the commit history was useless. Third time is the charm 馃檭
Fixes the bug where
({ a, ...R }, b = R, c = a) => {}was not transpiled correctly iftransform-function-parameterswas not enabled.I fixed it by modifying
convertFunctionParamsto accept a function to transform rest elements.