Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polish: align optional chain whitespace behavior to their sibiling #11328

Merged
merged 1 commit into from Mar 24, 2020
Merged

polish: align optional chain whitespace behavior to their sibiling #11328

merged 1 commit into from Mar 24, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Mar 24, 2020

Q                       A
Tests Added + Pass? Yes
License MIT

I leave isHelper intact since our helper calls are non optional by definition.

@JLHwung JLHwung added PR: Polish 💅 A type of pull request used for our changelog categories pkg: generator labels Mar 24, 2020
@JLHwung JLHwung merged commit 8e7ef30 into babel:master Mar 24, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 24, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@jridgewell jridgewell jridgewell approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JLHwung @existentialism @jridgewell @nicolo-ribaudo