fix auto import error with whitespace JSXText #11354
Conversation
existentialism
added
PR: Bug Fix 🐛
| !(t.isJSXText(child) && child.value.trim() === ""), | ||
| ); | ||
|
|
||
| const validChildren = openingPath.parent.children.filter(child => { |
There was a problem hiding this comment.
Can we reuse t.react.buildChildren?
There was a problem hiding this comment.
t.react.buildChildren mutates the node. I can refactor it to return a value instead of mutating if that's okay with you.
There was a problem hiding this comment.
I can refactor it to return a value instead of mutating if that's okay with you.
I am okay with that if it turns out we does not depend on its mutation behaviors. BTW t.react.buildChildren is undocumented so it is likely only used by our plugins.
Since t.react.buildChildren is also scattered in this plugin. It will be of great help to maintainers if we can preserve consistency or we clearly identify the different scenarios.
There was a problem hiding this comment.
Ah actually maybe you're right. Let me update this diff
lunaruan
force-pushed
the
fix_symbol_error
branch
from
873b2e2
to
6a2bcbb
Compare
|
|
||
| class MobileHomeActivityTaskPriorityIcon extends React.PureComponent { | ||
| render() { | ||
| return <Text> {this.props.value}nbsp;</Text>; |
There was a problem hiding this comment.
Is this supposed to be ?
| return <Text> {this.props.value}nbsp;</Text>; | |
| return <Text> {this.props.value} </Text>; |
|
|
||
| class MobileHomeActivityTaskPriorityIcon extends React.PureComponent { | ||
| render() { | ||
| return <Text> {this.props.value}nbsp;</Text>; |
There was a problem hiding this comment.
Ditto.
| return <Text> {this.props.value}nbsp;</Text>; | |
| return <Text> {this.props.value} </Text>; |
lunaruan
force-pushed
the
fix_symbol_error
branch
from
6a2bcbb
to
52eee29
Compare
github-actions
bot
added
the
outdated
The new JSX auto import React has a bug where it ignores valid whitespace text when calculating whether to import
jsxorjsxs. This fixes it by stripping JSXText the same way thatt.react.buildChildrenstrips JSXText so that the children calculated are consistent with each other.