New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace backslashes with forward slashes from resolved path for … #11366
fix: replace backslashes with forward slashes from resolved path for … #11366
Conversation
…windows environments
@johannes-z Could you add a test for this change? Since the test should only run on windows, you can specify it like it has been done in |
@nicolo-ribaudo Sure, I can try. I have no experience with the test suite. Are there docs for it? I also would need to know how to run it 😓 |
@johannes-z check out https://github.com/babel/babel/blob/master/CONTRIBUTING.md#running-lintingtests, and let us know if you run into any problems so we can improve the docs! Also, feel free to join our Slack if you need any help! |
I'm on Windows here and unable to run the test suite:
|
Try running |
It worked executing, but I'm getting errors:
Ok nevermind, I figured it out. The docs should be improved a little for windows. It's quite hard to figure out how everything works if you're not familiar with the project setup: yarn lerna bootstrap
yarn gulp build
yarn jest babel-plugin-transform-runtime Now it works. |
@johannes-z We are thinking about migrating away from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch anyway!
…windows environments
See #11357