Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify scope.hasReferences implementation #11368

Merged
merged 1 commit into from Apr 3, 2020

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Apr 2, 2020

references are only ever registered on the program scope, so there is no need to iterate through all parent scopes - we can just jump to the program one

@Andarist Andarist added the PR: Polish 💅 A type of pull request used for our changelog categories label Apr 2, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit aeebc08 into master Apr 3, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the simplify-has-references branch April 3, 2020 22:44
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 4, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: traverse (scope) PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants