Unify parens printing for postfix-like expressions #11382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
JLHwung
reviewed
Apr 6, 2020
| @@ -32,6 +32,15 @@ const isClassExtendsClause = (node: Object, parent: Object): boolean => | |||
| (t.isClassDeclaration(parent) || t.isClassExpression(parent)) && | |||
| parent.superClass === node; | |||
|
|
|||
| const isPostfixExpression = (node: Object, parent: Object) => | |||
There was a problem hiding this comment.
AFAIK the postfix expression is used to describe a way of how the operator and its operands are arranged, so I am confused about the term here.
The Spec provides a term LeftHandSideExpression and I think we can stick with that.
There was a problem hiding this comment.
LeftHandSideExpression doesn't work, because it also covers PrimaryExpression.
I initially called this "postfix" because TS's ! is a postfix operator, and because in foo() and foo.bar, () and .bar are "postfixes" of the main foo expression 😅
Maybe hasPostfixPart?
There was a problem hiding this comment.
I'm fine with hasPostfixPart.
nicolo-ribaudo
changed the title
...(), ...[0], ...! and template tags
nicolo-ribaudo
changed the title
...(), ...[0], ...! and template tags
existentialism
approved these changes
Apr 7, 2020
JLHwung
approved these changes
Apr 7, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This blocks #10961