contributing.md updates [skip ci] #11403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzoo
added
the
PR: Docs 📝
JLHwung
reviewed
Apr 10, 2020
CONTRIBUTING.md
Outdated
|
|
||
| Make sure that Yarn is installed with version >= `0.28.0`. | ||
| Installation instructions can be found here: https://yarnpkg.com/en/docs/install. | ||
| *Yarn*: Make sure that Yarn is [installed](https://classic.yarnpkg.com/en/docs/install) with version >= `0.28.0`. |
There was a problem hiding this comment.
May worth referring to http://gnuwin32.sourceforge.net/packages/make.htm for Windows developers.
There was a problem hiding this comment.
yeah I'm trying to make this work on windows lol and hitting the make issue 😛
Co-Authored-By: Brian Ng <bng412@gmail.com>
existentialism
approved these changes
Apr 13, 2020
JLHwung
approved these changes
Apr 13, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some changes to contributing to simplify