Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable import.meta by default in @babel/parser (#11364) #11406

Merged
merged 3 commits into from May 24, 2020
Merged

Enable import.meta by default in @babel/parser (#11364) #11406

merged 3 commits into from May 24, 2020

Conversation

kik-o
Copy link
Contributor

@kik-o kik-o commented Apr 11, 2020 •
edited by JLHwung

Q                       A 🗺️
Fixes Fixes #11364
Patch: Moved files, removed hasPlugin() & expectPlugin ✅
Major: Breaking Change? No
Minor: New Feature? Yes
Tests Added + Pass? Yes 💯
Documentation PR Link
Any Dependency Changes? No
License MIT
  • Moved experimental test files for importMeta into ES2020 folder.
  • Also removed checks for hasPlugin() & expectPlugin()
  • Removed useless test to check if importMeta exists

@kik-o kik-o changed the title ❌ Enable import.meta by default in @babel/parser (#11364) ❌ Enable import.meta by default in @babel/parser (#11364) Apr 11, 2020
@nicolo-ribaudo nicolo-ribaudo added pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories Spec: import.meta labels Apr 11, 2020
@nicolo-ribaudo nicolo-ribaudo added this to the v7.10.0 milestone Apr 11, 2020
@kik-o
Copy link
Contributor Author

kik-o commented Apr 23, 2020 •
edited

Thank you for all the incredibly useful and informative notes, guys! The following issues have been resolved:

  • Removed final this.hasPlugin error check
  • Removed import meta redundant test
  • Added relevant module detection test

@kik-o kik-o closed this Apr 23, 2020
@kik-o kik-o reopened this Apr 23, 2020
@nicolo-ribaudo
Copy link
Member

@kk-o I don't see any new commit 😅

@kik-o
Copy link
Contributor Author

kik-o commented Apr 24, 2020 •
edited

Sorry for the hiccup! Must have not pushed my changes but things should be good to go now 🚀

Tests passed on my end!

@kik-o @nicolo-ribaudo
❌ Enable import.meta by default in @babel/parser (babel#11364)
549ca12 
* move files, remove hasPlugin() & expectPlugin()
@kik-o @nicolo-ribaudo
FIx: removed redundant test, re-added relevant test, updated Errors o…
0cf8307 
…bject

• Removed "without-dynamic-import" test as
• Removed unused code from the Errors object
• Re-added relevant importMeta test
@babel-bot
Copy link
Collaborator

babel-bot commented Apr 24, 2020 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/21290/

nicolo-ribaudo
nicolo-ribaudo reviewed Apr 24, 2020
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(I have rebased your commits)

nicolo-ribaudo
nicolo-ribaudo approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(I have rebased your commits)

@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Apr 24, 2020
@nicolo-ribaudo nicolo-ribaudo changed the title ❌ Enable import.meta by default in @babel/parser (#11364) Enable import.meta by default in @babel/parser (#11364) Apr 26, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit 5dd7f43 into babel:master May 24, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 24, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release Spec: import.meta
Projects
None yet
Milestone
v7.10.0
Development

Successfully merging this pull request may close these issues.

Enable import.meta by default in @babel/parser
4 participants
@kik-o @nicolo-ribaudo @babel-bot @existentialism