Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade @babel/* deps #11422

Merged
merged 2 commits into from Apr 15, 2020
Merged

chore: upgrade @babel/* deps #11422

merged 2 commits into from Apr 15, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Apr 14, 2020

Q                       A
Fixed Issues? Per nodejs/node#32852 (comment)
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? Update @babel/* dev deps.
License MIT

@JLHwung JLHwung added PR: Internal 🏠 A type of pull request used for our changelog categories PR: Fixes failing main labels Apr 14, 2020
nicolo-ribaudo
nicolo-ribaudo approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove code to make things work ✔️

@hzoo
Copy link
Member

hzoo commented Apr 15, 2020

Guess should update ourselves every minor at least haha, although we have the smoke test for master?

@nicolo-ribaudo
Copy link
Member

The smoke tests didn't catch it because it's a Node.js breaking change, not something that we control.

@nicolo-ribaudo nicolo-ribaudo merged commit c85aafd into babel:master Apr 15, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the update-babel-deps branch April 15, 2020 14:57
@commit-lint commit-lint bot mentioned this pull request Apr 15, 2020
Merged
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Fixes failing main PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JLHwung @hzoo @nicolo-ribaudo @existentialism