[preset-env] Add browserslistEnv option
#11434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
pkg: preset-env
PR: New Feature 🚀
|
The failing tests should be fixed on master. |
JLHwung
reviewed
Apr 16, 2020
JLHwung
reviewed
Apr 16, 2020
| value = defaultValue; | ||
| } | ||
|
|
||
| if (typeof value !== "string" && typeof value !== "undefined") { |
There was a problem hiding this comment.
Suggested change
| if (typeof value !== "string" && typeof value !== "undefined") { | |
| else if (typeof value !== "string") { |
JLHwung
reviewed
Apr 17, 2020
existentialism
approved these changes
Apr 17, 2020
JLHwung
added
the
PR: Ready to be Merged
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a71b140:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/22657/ |
nicolo-ribaudo
changed the title
preset-env] Add browserslistEnv option
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new option to
preset-env, which allows the user to specify an environment which is passed forward to browserslist. Continuation of the work from #9161 based on this comment: #9161 (comment)