refactor(babel-node): Refactor babel-node tests configuration #11440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arku
force-pushed
the
refactor/babel-node-test-config
branch
from
6095c8b
to
a04bb45
Compare
nicolo-ribaudo
approved these changes
Apr 20, 2020
existentialism
approved these changes
Apr 20, 2020
hzoo
approved these changes
Apr 20, 2020
JLHwung
added
the
PR: Internal 🏠
arku
added a commit
to arku/babel
that referenced
this pull request
Apr 20, 2020
arku
added a commit
to arku/babel
that referenced
this pull request
Apr 21, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is blocking #11436. The babel-node
requiretest in #11436 which tries to parse JSX fails because of the default JSX compilation runtime change toautomatic. To fix, I had to pass{ runtime: 'classic' }option to the react preset here. @JLHwung suggested refactoring the test configuration setup in a separate PR against master (to not wait until #11436 gets merged).