Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set exprAllowed to false for star token #11449

Merged
merged 1 commit into from Apr 21, 2020
Merged

Set exprAllowed to false for star token #11449

merged 1 commit into from Apr 21, 2020

Conversation

existentialism
Copy link
Member

Q                       A
Fixed Issues? Fixes #11435
Patch: Bug Fix? Y
Major: Breaking Change? N
Minor: New Feature? N
Tests Added + Pass? Y/Y
License MIT

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser labels Apr 20, 2020
@nicolo-ribaudo
Copy link
Member

Do we have a test for a * /b/? (where / starts an expression after *).

@existentialism
Copy link
Member Author

@nicolo-ribaudo added some, couldn't find any

nicolo-ribaudo
nicolo-ribaudo approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@existentialism existentialism merged commit 40c517e into master Apr 21, 2020
@existentialism existentialism deleted the issue11435 branch April 21, 2020 19:22
@nicolo-ribaudo
Copy link
Member

@existentialism Could you update the flow tests whitelist file? https://github.com/facebook/flow/blob/master/src/parser/test/flow/async_generators/migrated_0007.js isn't failing anymore.

@existentialism
Copy link
Member Author

@nicolo-ribaudo good catch

@existentialism existentialism mentioned this pull request Apr 21, 2020
Merged
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anonymous generator function expression with typescript generic fails to parse
3 participants
@existentialism @nicolo-ribaudo @JLHwung