Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class proposals to shipped proposals #11451

Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Apr 20, 2020

Q                       A
Fixed Issues? Add proposal-private-methods and proposal-class-properties to preset-env (behind shippedProposals flag)
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link babel/website#2229
Any Dependency Changes?
License MIT

This PR contains commits from #11450.

Chrome 84 has enabled private-methods support by default, now it's time to include all the stage-3 class features into preset-env.

@JLHwung JLHwung added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: preset-env labels Apr 20, 2020
@JLHwung JLHwung mentioned this pull request Apr 21, 2020
@JLHwung JLHwung force-pushed the add-class-proposals-to-shipped-proposals branch from b98312c to c4302b4 Compare April 21, 2020 16:24
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@JLHwung JLHwung force-pushed the add-class-proposals-to-shipped-proposals branch from c4302b4 to bb20ba6 Compare April 22, 2020 16:15
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/21213/

@nicolo-ribaudo
Copy link
Member

Hi @babel-bot, we missed you ❤️

@nicolo-ribaudo nicolo-ribaudo added this to the v7.10.0 milestone Apr 26, 2020
@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Apr 26, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit 93a5005 into babel:master May 24, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the add-class-proposals-to-shipped-proposals branch May 24, 2020 20:32
edmorley added a commit to neutrinojs/neutrino that referenced this pull request Jun 8, 2020
Enabling this means that preset-env now injects additional plugins for
any features that aren't yet stage 3, but have been shipped in at least
one browser (meaning they are as good as finalised):
https://babeljs.io/docs/en/babel-preset-env#shippedproposals

Using this new mode also means we no longer need to manually include the
`@babel/plugin-proposal-class-properties` plugin, since it's included
in the shipped proposals list as of Babel 7.10.0:
babel/babel#11451
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 24, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants