Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove < x.y.z engines specification #11456

Merged
merged 2 commits into from Apr 21, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Apr 21, 2020

Q                       A
Tests Added + Pass? Yes
Documentation PR Link
License MIT

Here we remove the < x.y.z in the root project engine specifications. This also aligns to what we did in @babel/core. Hopefully it should fix our failing master due to the release of Node.js 14.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Apr 21, 2020
@@ -13,7 +13,6 @@ env:

install: skip
before_script:
- curl -o- -L https://yarnpkg.com/install.sh | bash
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also removed yarn update because:

  1. after these years the bundled yarn version in CI is reasonably new.
  2. yarnpkg.com could fail, i.e. https://travis-ci.com/github/JLHwung/babel/jobs/321733324

@nicolo-ribaudo nicolo-ribaudo merged commit d18d465 into babel:master Apr 21, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Fixes failing main PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants