Add some parser missing plugins errors #11478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Polish 💅
JLHwung
commented
Apr 24, 2020
| "plugins": [] | ||
| } | ||
| "throws": "This experimental syntax requires enabling the parser plugin: 'numericSeparator' (1:3)" | ||
| } |
There was a problem hiding this comment.
The diff here may be a bit confusing as I also remove the unused bigint missing plugin errors.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/21302/ |
kaicataldo
approved these changes
Apr 24, 2020
existentialism
approved these changes
Apr 25, 2020
nicolo-ribaudo
approved these changes
Apr 25, 2020
|
Thanks! |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements missing parser plugins check on
private-properties,numeric-separatorsandrecord-and-tuple(partially).The
record-and-tuplesupports missing plugins error on reading#{, I don't intend to supports#[because it will throw missingrecord-and-tupleerror when a computed private properties are used (disallowed by the spec), which is apparently misleading.The implementation of missing plugins error does not introduce extra lookahead so we can offer better error message without performance sacrifice.
Additional context: I find this issue when reviewing #11372.
Error message comparison: This branch v.s. master. (Thanks to the busy @babel-bot)