Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update AST spec #11492

Merged
merged 3 commits into from Apr 28, 2020
Merged

docs: update AST spec #11492

merged 3 commits into from Apr 28, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Apr 27, 2020

Q                       A
License MIT

Added BigIntLiteral and logical assignment operators. Also refined some interface declarations.

I leave OptionalCallExpression undocumented as in ESTree it is still highly debated and we should decide in the future whether we will go with the ESTree design.

@JLHwung JLHwung added PR: Docs 📝 A type of pull request used for our changelog categories pkg: parser labels Apr 27, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 20d0c89:

Sandbox Source
frosty-tesla-p2hfz Configuration
cranky-yalow-ogb17 Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Apr 27, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/21483/

Co-Authored-By: Brian Ng <bng412@gmail.com>
@nicolo-ribaudo
Copy link
Member

I wonder if we could somehow auto-generate this file by adding JSDoc to the definitions in @babel/types

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, also thinking the same as @nicolo-ribaudo 😄 (generating via types?)

@hzoo hzoo merged commit fa98a0a into babel:master Apr 28, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 29, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Docs 📝 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants