Update compat table script #11496
Update compat table script #11496
Conversation
nicolo-ribaudo
added
PR: Internal 🏠
| @@ -370,7 +371,7 @@ | |||
| "ios": "6", | |||
| "phantom": "2", | |||
| "samsung": "1", | |||
| "electron": "5" | |||
There was a problem hiding this comment.
Electron 5 is Chrome 72 (while this plugin is needed for Chrome <=7).
| @@ -384,6 +385,6 @@ | |||
| "ios": "6", | |||
| "phantom": "2", | |||
| "samsung": "1", | |||
| "electron": "0.2" | |||
| "electron": "0.20" | |||
There was a problem hiding this comment.
This is what happens when you consider versions as if they were decimal numbers.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/21529/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 88c8f5d:
|
|
|
| @@ -16,5 +16,5 @@ fi | |||
|
|
|||
| rm -rf build/compat-table | |||
| mkdir -p build | |||
| git clone --branch=gh-pages --single-branch --shallow-since=2020-04-20 https://github.com/kangax/compat-table.git build/compat-table | |||
| git clone --branch=gh-pages --single-branch --shallow-since=2020-04-01 https://github.com/kangax/compat-table.git build/compat-table | |||
There was a problem hiding this comment.
I think this is a bug of GitHub.
$ git show --pretty=fuller HEAD
commit 9e07df3875d8416af85cf523716519e9dd1e5e44 (HEAD -> gh-pages, upstream/gh-pages, upstream/HEAD)
Author: Nicolò Ribaudo <***>
AuthorDate: Fri Apr 17 15:06:37 2020 +0200
Commit: Jordan Harband <***>
CommitDate: Fri Apr 17 15:06:37 2020 +0200
The CommitDate should be the time when the PR is merged instead of when the PR is authored. Note that--shallow-since filters history by CommitDate so it should have been included in --shallow-since=2020-04-20 if the history is indeed chronological.
$ git rev-list HEAD --since=2020-04-20
(empty)
$ git rev-list HEAD~ --since=2020-04-20
0243431898be45cf53aed6c5b7332265cf7e69a8
6e9e589e966ec4b69ea35c63d55cf7d800ee94b6
989fad76f621c260f304d75c07c386c4a1857072
20a151274a2584175a9841e19bbd3098315c8868
df1466b4ddae4c1c9d8b385332a800eeb7f28049
58fca823e2dbb0c94774cc5f9a970c165deffeff
github-actions
bot
added
the
outdated
Fixes #1, Fixes #2Ref - compat-table/compat-table#1605
The changes in the electron versions are because different electron versions are mapped to a single chrome version. For example, Chrome 66 -> [Electron 3, Electron 3.1]. The old script used the highest electron version, but we should use the lowest one.