Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't elide jsx pragma import namespaces #11523

Merged
merged 2 commits into from May 14, 2020

Conversation

jquense
Copy link
Contributor

@jquense jquense commented May 5, 2020

Q                       A
Fixed Issues?
Patch: Bug Fix? X
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The logic to avoid removing pragma'd imports is less specific than its react counterpart and doesn't handle when files specify both @jsx and @jsxFrag very well. In particular this pattern is handled fine by the react transform but removed by TS

/** @jsx _j.jsx **/
/** @jsxFrag _j.F **/

import * as _j from "astroturf/jsx";

<><div/></>

The above is required BTW, b/c named imports don't work here for some reason: repl link, note that the fragment is incorrect

There should also be a separate plugin option for jsxFragmentPragma but i figured that was not necessary here

@babel-bot
Copy link
Collaborator

babel-bot commented May 5, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/21835/

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 27c5224:

Sandbox Source
upbeat-framework-5n4ml Configuration
pedantic-brook-90uxz Configuration

nicolo-ribaudo
nicolo-ribaudo previously approved these changes May 5, 2020
@nicolo-ribaudo nicolo-ribaudo dismissed their stale review May 5, 2020 17:49

According to CI, this doesn't fix the issue 🤔

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: jsx labels May 5, 2020
@jquense
Copy link
Contributor Author

jquense commented May 5, 2020

very confusing. let me see if i forgot to push something

@jquense
Copy link
Contributor Author

jquense commented May 13, 2020

should be fixed!

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit de8264c into babel:master May 14, 2020
@jquense jquense deleted the ts-jsx-pragma branch May 14, 2020 14:20
@jquense
Copy link
Contributor Author

jquense commented May 14, 2020

🙇

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: jsx outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants