New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't elide jsx pragma import namespaces #11523
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/21835/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 27c5224:
|
According to CI, this doesn't fix the issue 🤔
very confusing. let me see if i forgot to push something |
should be fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
🙇 |
The logic to avoid removing pragma'd imports is less specific than its react counterpart and doesn't handle when files specify both
@jsx
and@jsxFrag
very well. In particular this pattern is handled fine by the react transform but removed by TSThe above is required BTW, b/c named imports don't work here for some reason: repl link, note that the fragment is incorrect
There should also be a separate plugin option for jsxFragmentPragma but i figured that was not necessary here