New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade rollup to 1.27.9 #11538
Downgrade rollup to 1.27.9 #11538
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 92d57e0:
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/21995/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue can be reproducible on https://rollupjs.org/repl/?version=2.0.0 (copy paste the regjsparser
source), do we have an upstream issue to track?
Updates: I have created an upstream issue: rollup/rollup#3543.
|
We need to build standalone to test it 🤷 |
@nicolo-ribaudo Currently Babel can work on Node.js 6 and it is tested on Node.js 6, but Babel may not be built on Then we can consider upgrading |
@JLHwung It seems to be fixed when using https://rollupjs.org/repl/?version=2.8.2 Regarding the dependencies updates: I think we use rollup to build the parser even on Node.js 6. |
e77a04c
to
92d57e0
Compare
Suggest to have a look at https://github.com/zeit/ncc I was troubled by various rollup issues (especially break nodejs v14) before, moved to ncc with zero config, never want to go back. |
It lists "Only supports Node.js programs as input / output" as a design goal, and our output code must run on browsers 🤷 |
It generates commonjs code. As long as you don't use nodejs api, there is no reason the code cannot run on browser. I got few projects using ncc to generate runnable code in both browser and nodejs. |
Example here ncc doesn't support output to stdout, so there are two steps in my build.
|
This is a partial revert of #11233. Due to a bug in rollup's tree-shaking logic,
@babel/standalone
didn't contain some necessary code. (#11534 (comment))We cannot upgrade to Rollup 2 yet because it requires Node.js 10.