Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade rollup to 1.27.9 #11538

Merged
merged 2 commits into from May 12, 2020
Merged

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues? Fixes #11534
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This is a partial revert of #11233. Due to a bug in rollup's tree-shaking logic, @babel/standalone didn't contain some necessary code. (#11534 (comment))

We cannot upgrade to Rollup 2 yet because it requires Node.js 10.

@nicolo-ribaudo nicolo-ribaudo added i: regression PR: Revert ↩️ A type of pull request used for our changelog categories labels May 8, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 92d57e0:

Sandbox Source
focused-star-j74n0 Configuration
agitated-drake-ys1zn Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented May 8, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/21995/

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue can be reproducible on https://rollupjs.org/repl/?version=2.0.0 (copy paste the regjsparser source), do we have an upstream issue to track?

Updates: I have created an upstream issue: rollup/rollup#3543.

@hzoo
Copy link
Member

hzoo commented May 8, 2020

We cannot upgrade to Rollup 2 yet because it requires Node.js 10.
Are we building standalone on every node version? Maybe we could just do it on latest?

@nicolo-ribaudo
Copy link
Member Author

We need to build standalone to test it 🤷
We can try to update rollup in the next-8-dev branch.

@JLHwung
Copy link
Contributor

JLHwung commented May 8, 2020

@nicolo-ribaudo Currently @babel/standalone is only tested on latest node. If we interpret node >= 6 support as:

Babel can work on Node.js 6 and it is tested on Node.js 6, but Babel may not be built on node >= 6.

Then we can consider upgrading rollup and ESLint, etc. but leave jest stay on v24 to run tests only. I believe none of core team members are developing babel on node.js 6, and this change should be ideally invisible to users.

@nicolo-ribaudo
Copy link
Member Author

@JLHwung It seems to be fixed when using https://rollupjs.org/repl/?version=2.8.2

Regarding the dependencies updates: I think we use rollup to build the parser even on Node.js 6.

@JLHwung JLHwung merged commit 0734754 into babel:master May 12, 2020
@3cp
Copy link
Contributor

3cp commented May 27, 2020

Suggest to have a look at https://github.com/zeit/ncc

I was troubled by various rollup issues (especially break nodejs v14) before, moved to ncc with zero config, never want to go back.

@nicolo-ribaudo nicolo-ribaudo deleted the rollup-downgrade branch May 27, 2020 07:58
@nicolo-ribaudo
Copy link
Member Author

It lists "Only supports Node.js programs as input / output" as a design goal, and our output code must run on browsers 🤷

@3cp
Copy link
Contributor

3cp commented May 27, 2020

It generates commonjs code. As long as you don't use nodejs api, there is no reason the code cannot run on browser. I got few projects using ncc to generate runnable code in both browser and nodejs.

@3cp
Copy link
Contributor

3cp commented May 27, 2020

Example here
https://github.com/buttonwoodcx/bcx-validation/blob/55a17d6a10ab29c45fa0bf2dd37f1532f7159260/package.json#L31-L32

ncc doesn't support output to stdout, so there are two steps in my build.

  1. ncc to pack all files into one js.
  2. babel to transpile the bundle to es5 for IE11.

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Revert ↩️ A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@babel/standalone can't parse any quantifiers in unicode regexes
7 participants