Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add isLiteralPropertyName to parser utils #11547

Merged
merged 5 commits into from May 14, 2020
Merged

refactor: add isLiteralPropertyName to parser utils #11547

merged 5 commits into from May 14, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented May 12, 2020 •
edited

Q                       A
Fixed Issues? BigIntLiteral should be allowed in name of async method and accessors, also fixes #11555
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR is a follow-up to #10955, found this issue when reading sources.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser labels May 12, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 12, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f36586e:

Sandbox Source
prod-wave-u0o06 Configuration
distracted-jepsen-2g36o Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented May 12, 2020 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/22188/

@JLHwung
Copy link
Contributor Author

JLHwung commented May 13, 2020

Note for myself: work on a fix on #11555 based on this PR.

@JLHwung JLHwung merged commit 2f31ecf into babel:master May 14, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigInt Literal not parsed in Typescript interface declaration
4 participants
@JLHwung @babel-bot @existentialism @nicolo-ribaudo