Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check for privateMap's existence #11571

Merged
merged 8 commits into from May 30, 2020
Merged

Add a check for privateMap's existence #11571

merged 8 commits into from May 30, 2020

Conversation

AjayPoshak
Copy link
Contributor

@AjayPoshak AjayPoshak commented May 16, 2020 •
edited

Q                       A
Fixed Issues? Fixes #11414
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator

babel-bot commented May 16, 2020 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/22770/

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 16, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6f7e1f9:

Sandbox Source
gifted-nightingale-xysmq Configuration
magical-lumiere-8cvl7 Configuration

@nicolo-ribaudo
Copy link
Member

Instead of explicitly handling this case, would it be possible to always ensure that the WeakMap is always defined, as proposed at #11414 (comment)?

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Class Fields labels May 16, 2020
@nicolo-ribaudo
Copy link
Member

Could you add a new test with the code mentioned in #11414? 🙏

Also, CI failure should is fixed on master.

nicolo-ribaudo
nicolo-ribaudo approved these changes May 30, 2020
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit b1923fd into babel:master May 30, 2020
@existentialism existentialism mentioned this pull request May 31, 2020
Merged
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 30, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Class Fields
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Babel throws confusing error when private property is used as computed key
4 participants
@AjayPoshak @babel-bot @nicolo-ribaudo @jridgewell