Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scope.rename() missing identifier in VariableDeclarator #11595

Merged
merged 5 commits into from May 26, 2020

Conversation

yulanggong
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #11591
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 22, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3488a84:

Sandbox Source
quizzical-varahamihira-5mkk0 Configuration
lively-sun-yjrt6 Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented May 22, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/22824/

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: traverse (scope) labels May 22, 2020
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure is fixed on master

@yulanggong yulanggong requested a review from JLHwung May 26, 2020 02:21
@nicolo-ribaudo nicolo-ribaudo changed the title Fixed #11591 babel-traverse scope.rename() missing identifier in VariableDeclarator scope.rename() missing identifier in VariableDeclarator May 26, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit 429840d into babel:master May 26, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 26, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: traverse (scope) PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

babel-traverse Scope.rename bad case
5 participants