Fix standalone tag when data-type is not set. #11624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4adbbfb:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/22977/ |
|
Thanks! |
nicolo-ribaudo
previously approved these changes
May 27, 2020
nicolo-ribaudo
added
pkg: standalone
PR: Bug Fix 🐛
nicolo-ribaudo
dismissed
their stale review
I see an empty string i my browser 🙃 Maybe it's better to just do if (!script.type)?
|
Yeah let's go with a |
dfabulich
force-pushed
the
standalone-11621
branch
from
d2e5902
to
4adbbfb
Compare
|
Switched to a truthy check. I'm a bit surprised to see that y'all had an empty string; I tested the previous version on Chrome 83, Safari 13.1, and Firefox 76, both with and without a |
nicolo-ribaudo
approved these changes
May 27, 2020
|
@dfabulich thanks for the quick fix! |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11621.
I thought
getAttributereturnedundefinedwhen the attribute was unset, but it actually returns null. 🤦♂️I manually tested this patch with and without a
data-typeattribute. (It appears that the babel-standalone script tag has no tests?? I might add some later, but for now, I want to fix this bug right away.)