Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: babel-eslint-parser passes through config options #11639

Merged
merged 4 commits into from May 29, 2020

Conversation

kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented May 28, 2020

Q                       A
Fixed Issues? refs #11334
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? 👍
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

As discussed in #11334, this PR allows for users to pass through Babel configuration options directly to Babel's parse method, allowing for @babel/eslint-parser to be used without a Babel configuration file.

We already have a few tests that cover this code path (see here). I feel like this is sufficient for now, but please let me know if you would rather I added more test cases.

cc @jharris4

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 28, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c200084:

Sandbox Source
peaceful-herschel-nugeh Configuration
modest-cloud-2ikbv Configuration

@kaicataldo kaicataldo added area: eslint PR: New Feature 🚀 A type of pull request used for our changelog categories labels May 28, 2020
@babel-bot
Copy link
Collaborator

babel-bot commented May 28, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/23146/

@jharris4
Copy link

@kaicataldo thanks so much for this, it's really awesome to see this finally get implemented!

If I still lived in Brooklyn (and if it weren't for covid) I'd buy you a beer. In the meantime is there a spot I can make a one off contribution towards your OSS work?

@kaicataldo kaicataldo changed the title feature: babel-eslint-plugin passes through config options feature: babel-eslint-parser passes through config options May 29, 2020
@kaicataldo
Copy link
Member Author

@jharris4 Thanks for the kind words ❤️

I currently have a GitHub Sponsors profile, but it unfortunately doesn't allow for one time donations.

Hit me up if you end up back in Brooklyn post-pandemic - would love to hang out!

@kaicataldo
Copy link
Member Author

Thanks for the reviews, all!

@kaicataldo kaicataldo merged commit 69198be into babel:master May 29, 2020
@kaicataldo kaicataldo deleted the pass-through-options branch May 29, 2020 19:00
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 29, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: eslint outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants