Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some test fixtures #11655

Merged
merged 1 commit into from May 31, 2020
Merged

Fix some test fixtures #11655

merged 1 commit into from May 31, 2020

Conversation

existentialism
Copy link
Member

@existentialism existentialism commented May 31, 2020 •
edited

Q                       A
Patch: Bug Fix? N
Major: Breaking Change? N
Minor: New Feature? N
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

#11571 missed some new tests from #11372 and #11634

@existentialism existentialism added PR: Internal 🏠 A type of pull request used for our changelog categories PR: Fixes failing main labels May 31, 2020
@babel-bot
Copy link
Collaborator

babel-bot commented May 31, 2020 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/23300/

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 31, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0d30ed1:

Sandbox Source
crazy-silence-g44tr Configuration
beautiful-smoke-cr2o3 Configuration

JLHwung
JLHwung approved these changes May 31, 2020
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green. ❤️

@existentialism
Copy link
Member Author

(Weird, my local jest is not finding a number of tests, so the original overwrite didn't catch them all... will investigate later 🤔)

@existentialism existentialism merged commit 3a3457d into master May 31, 2020
@existentialism existentialism deleted the fix-tests branch May 31, 2020 14:57
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 31, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Fixes failing main PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@existentialism @babel-bot @JLHwung