Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform NamedEvaluation of Anonymous Functions in Logical Assignment #11658

Merged
merged 1 commit into from Jun 3, 2020

Conversation

jridgewell
Copy link
Member

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This is a partial revert of #11370, updating the tests to match the new consensus.

I want to thank @arku for the initial PR!

This is a partial revert of babel#11370, updating the tests to match the [new consensus](babel/proposals#66 (comment)).
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f62ed55:

Sandbox Source
inspiring-hill-17gls Configuration
zealous-maxwell-09don Configuration

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/23357/

@existentialism existentialism added the PR: Spec Compliance 👓 A type of pull request used for our changelog categories label Jun 2, 2020
@nicolo-ribaudo
Copy link
Member

I'm glad to see that Babel's implementation helped finding this spec change 😄

@nicolo-ribaudo nicolo-ribaudo merged commit a3f0089 into babel:master Jun 3, 2020
@nicolo-ribaudo
Copy link
Member

I had to edit the commit name because it was too long

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 3, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Spec Compliance 👓 A type of pull request used for our changelog categories Spec: Logical Assignment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants