New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delete obj?.#x.a
support
#11669
Add delete obj?.#x.a
support
#11669
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/23514/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f226bc8:
|
function fnDeep() { | ||
return deep; | ||
} | ||
expect(() => delete Foo?.#self.unicorn).toThrow(TypeError); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since unicorn
is non configurable, delete Foo.#self.unicorn
will throw TypeError
, so we are sure that the regular path is invoked indeed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clever!
This PR is a follow-up to #11248, which supports
delete obj?.#x.a
in a similar way of #10806.This PR includes commits in #11662, I will rebase once that one is merged.