Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small typo #11682

Merged
merged 1 commit into from Jun 5, 2020
Merged

Fix small typo #11682

merged 1 commit into from Jun 5, 2020

Conversation

sajadtorkamani
Copy link
Contributor

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@JLHwung
Copy link
Contributor

JLHwung commented Jun 5, 2020

Can you run OVERWRITE=true yarn jest to update test fixtures?

@JLHwung JLHwung added PR: Polish 💅 A type of pull request used for our changelog categories area: typescript labels Jun 5, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e578668:

Sandbox Source
trusting-sara-pimly Configuration
cool-sunset-53sxx Configuration

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/23550/

@sajadtorkamani
Copy link
Contributor Author

Can you run OVERWRITE=true yarn jest to update test fixtures?

I ran this from the project root and all the tests passed (after a while!) but nothing else changed.

Running git status doesn't report any changes. Is this expected?

@JLHwung
Copy link
Contributor

JLHwung commented Jun 5, 2020

@sajadtorkamani Thanks. Ideally there should be a test covering this branch, but it is not blocking this PR.

@JLHwung JLHwung merged commit 9d289c1 into babel:master Jun 5, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 5, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sajadtorkamani @JLHwung @babel-bot