Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add React.createContext to @babel/plugin-transform-react-pure-annotat… #11685

Merged
merged 1 commit into from Jun 6, 2020
Merged

Add React.createContext to @babel/plugin-transform-react-pure-annotat… #11685

merged 1 commit into from Jun 6, 2020

Conversation

jessethomson
Copy link
Contributor

@jessethomson jessethomson commented Jun 5, 2020 •
edited

Add React.createContext to @babel/plugin-transform-react-pure-annotations

Q                       A
Fixed Issues? No
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? #11684
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/23556/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3093ede:

Sandbox Source
keen-browser-1m4b8 Configuration
angry-water-1ytse Configuration

@jessethomson jessethomson mentioned this pull request Jun 5, 2020
Closed
1 task
@JLHwung
Copy link
Contributor

JLHwung commented Jun 5, 2020

@babel/react

@nicolo-ribaudo nicolo-ribaudo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Jun 5, 2020
@nicolo-ribaudo
Copy link
Member

This definitely looks like an oversight in @devongovett's PR.

devongovett
devongovett approved these changes Jun 6, 2020
View reviewed changes
Copy link
Contributor

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks. 😄

@existentialism existentialism merged commit 426acf3 into babel:master Jun 6, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 5, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devongovett devongovett devongovett approved these changes

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: react outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jessethomson @babel-bot @JLHwung @nicolo-ribaudo @devongovett @existentialism