New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update spec-new
in CONTRIBUTING.md [skip ci]
#11706
Conversation
This comment has been minimized.
This comment has been minimized.
Also not if the experimental estree nodes change after that we implemented them (and they are free to do so). |
@nicolo-ribaudo Though it is called experimental in ESTree, the AST changes are still rare once it gets approved: https://github.com/estree/estree/commits/master/experimental We should document our AST stability policy somewhere. Here it works as a rough guideline to new contributors working on new language features. |
8b4baca
to
54a954f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
it would be nice to maybe document where/when we do things somewhere (I used to do it at https://github.com/babel/proposals, example like babel/proposals#18) so you can track history but it's been some work to keep it all organized/updated
Co-authored-by: Brian Ng <bng412@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Brian Ng <bng412@gmail.com>
Yeah a repo / issue tracking each proposals is always good-to-have but proves a bit overhead, at it is prone to become outdated compared to https://github.com/tc39/proposals. Currently we use labels to track issues related to specific proposals. It is easier to maintain rather than updating stages/status manually in |
This PR updates the process of developing a new babel plugin in this repo. It features a detailed checklist and an updated example of a new parser feature PR.
The process also requires an AST PR addressed in ESTree before implementation. By doing so we can gather more feedback, especially about the AST shape, before a new proposal is implemented in Babel. In the future we will follow ESTree unless the new AST is not consistent with current Babel AST.
/cc @nzakas @RReverser