[regression] Don't validate file.comments in @babel/types
#11752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0e34189:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/24769/ |
zxbodya
reviewed
Jun 27, 2020
| validate: assertEach(assertNodeType("Comment")), | ||
| validate: !process.env.BABEL_TYPES_8_BREAKING | ||
| ? Object.assign(() => {}, { each: { type: "Comment" } }) | ||
| : assertEach(assertNodeType("Comment")), |
There was a problem hiding this comment.
one thing, I noticed, when looking into referred issue:
assertNodeType("Comment") results in correct typescript types, but actual check is not correct instead it should be assertNodeType("CommentBlock", "CommentLine")
zxbodya
approved these changes
Jun 27, 2020
existentialism
approved these changes
Jun 27, 2020
JLHwung
reviewed
Jun 29, 2020
JLHwung
approved these changes
Jun 29, 2020
[skip ci] Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #11687 we introduced a new valid check, but it breaks Jest. Let's defer it to Babel 8.