Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove babel-register generated test artifacts #11776

Merged
merged 2 commits into from Jul 1, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 1, 2020

Q                       A
Fixed Issues? Our Travis CI build is always packing a new n_m cache after tests: https://travis-ci.com/github/babel/babel/jobs/356503785#L1076
License MIT

This PR refines babel-register tests to ensure that they output to customized cache path and removed after test. I also add a general remove node_modules/.cache step to make test-clean as our last resort.

Hopefully Travis CI should not pack a new n_m cache after test is finished. (See https://travis-ci.com/github/babel/babel/jobs/356530518#L1082)

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jul 1, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f896c4f:

Sandbox Source
patient-sea-hvcwd Configuration
lucid-chatelet-03jwr Configuration

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/25023/

@JLHwung JLHwung merged commit ae1e40a into babel:main Jul 1, 2020
@JLHwung JLHwung deleted the remove-test-artifacts-babel-register branch July 1, 2020 21:07
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 1, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants