babel-traverse: prefer clearer, reduced-bias option naming #11791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9dc946d:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/25413/ |
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
nicolo-ribaudo
added
the
PR: Internal 🏠
nicolo-ribaudo
approved these changes
Jul 5, 2020
JLHwung
added
PR: Polish 💅
JLHwung
added
the
PR: Ready to be Merged
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed change attempts to clarify the naming of a
babel-traverseoption (noticed during development of #11790) by using language that aims to be clearer for non-native English speakers and has reduced modern connotations of bias.Since the option doesn't appear to be widely used (ref) and doesn't appear to be documented(ref, ref), this changeset doesn't attempt to maintain backwards compatibility, although a release note to indicate that it is a breaking change would be useful.