Always retain lines for async arrow #11836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8cae946:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/25977/ |
existentialism
added
pkg: generator
PR: Bug Fix 🐛
JLHwung
reviewed
Jul 15, 2020
| @@ -109,7 +109,8 @@ export function ArrowFunctionExpression(node: Object) { | |||
| if ( | |||
| node.params.length === 1 && | |||
| t.isIdentifier(firstParam) && | |||
| !hasTypes(node, firstParam) | |||
| !hasTypes(node, firstParam) && | |||
| !node.async | |||
| ) { | |||
| if ( | |||
| this.format.retainLines && | |||
There was a problem hiding this comment.
We can move node.async to here
this.format.retainLines || node.async
so we are instructing that if async presents, we try to retain lines and print ( if the function body is in different lines with the async arrow.
|
Thanks @JLHwung, looks like that does the trick. |
nicolo-ribaudo
changed the title
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab at fixing #11830, fixes the bug but has other issues.
Since the fix is to always include parentheses for arrow functions, it breaks the following tests:
generation/edgecase › single arg async arrow with retainlinesgeneration/types › ArrowFunctionExpressionI'm not sure what we should do here, ideally I guess we should only wrap the param in parentheses if there's a comment proceeding the param, though I don't have any idea how to do that.