refactor: replace caniuse-db by mdn-browser-compat-data #11838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
the
PR: Internal 🏠
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 842112b:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26084/ |
JLHwung
commented
Jul 14, 2020
4 tasks
JLHwung
force-pushed
the
use-mdn-browser-compat-data
branch
from
8ed0873
to
d15ce7d
Compare
JLHwung
force-pushed
the
use-mdn-browser-compat-data
branch
from
d15ce7d
to
842112b
Compare
| }; | ||
| fs.writeFileSync(dataPath, `${JSON.stringify(data, null, 2)}\n`); | ||
| exports.process = process; |
There was a problem hiding this comment.
What is this needed for?
There was a problem hiding this comment.
nicolo-ribaudo
approved these changes
Jul 20, 2020
existentialism
approved these changes
Jul 20, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
es6.modulescompat-data should includenode: 13.2.In this PR I have replaced
caniuse-dbbymdn-browser-compat-datawhen building the modules support in@babel/compat-data. The rationale here iscaniusestates that the support data ofes6-modulesare frommdn/browser-compat-dataexport * as nssupport, which enables us to includeexport-namespace-fromin thepreset-env.mdn-browser-compat-datais easier to process thancaniuse-db(no moregetLowestImplementedVersions)caniusedoes not havenodejssupport data