Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly set innerEndPos in CoverParenthesizedExpressionAndArrowParameterList #11847

Merged
merged 1 commit into from Jul 16, 2020
Merged

fix: correctly set innerEndPos in CoverParenthesizedExpressionAndArrowParameterList #11847

merged 1 commit into from Jul 16, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 16, 2020 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #10436
Patch: Bug Fix? Yes
License MIT

The lastTokEnd points to the last non-whitespace position of the last element of a sequence expression, which is also used in finishNode.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser labels Jul 16, 2020
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26042/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7462cf7:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@existentialism existentialism merged commit f4eeff9 into babel:main Jul 16, 2020
@existentialism existentialism deleted the fix-10436 branch July 16, 2020 22:11
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hzoo hzoo hzoo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[parser] Multi line group location ending
4 participants
@JLHwung @babel-bot @hzoo @existentialism